fix: resolve Sandpack examples not displaying in Activity documentation
#1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1nxeo
requested review from
eomttt,
gnujoow,
hg-pyun and
lumirlumir
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
wishket-pjw
approved these changes
Oct 15, 2025
hg-pyun
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
요건 근본적으로 기존 문서를 빠르게 따라잡아야겠군요. 일단 이렇게 패치하는 것에는 동의합니다.
https://github.com/reactjs/react.dev/blob/main/src/content/reference/react/Activity.md?plain=1
|
#1342 에서, 패키지 버전을 따라가는 쪽으로 수정이 이루어졌습니다. 따라서 위 수정내용은 반영이 불필요하단 판단이 들어요. 반영되지 않아서 아쉽지만, 기여해주셔서 감사합니다 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activity의 예제가 제대로 보이지 않는 이슈 수정Problem
"react": "experimental"형태로만 명시되어 react와 react-dom이 서로 다른 해시의 experimental 버전으로 설치됨Proposed Changes
모든 Sandpack 예제에서 package.json 블록 제거
experimental 기능 import 시 fallback 패턴 적용하도록 변경
영어 문서와 동일한 방식으로 통일
필수 확인 사항
textlint가이드Textlint Guide선택 확인 사항
refs #1339